Attention is currently required from: Ravi kumar.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39614 )
Change subject: sc7180: Add display dsi interface programming
......................................................................
Patch Set 40:
(1 comment)
File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/39614/comment/e54e1488_93b12d3a
PS40, Line 105: hbp = edid->mode.hbl - edid->mode.hso;
video mode active h part is active + backporch+ pusle width. […]
Thanks. Can you please upload a CL to do that (here and in sc7280 if there's equivalent code there)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie64354ce8bc2a64b891fb9478fbca38d6ec4c321
Gerrit-Change-Number: 39614
Gerrit-PatchSet: 40
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Comment-Date: Tue, 21 Sep 2021 23:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment