Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35370 )
Change subject: mb/asrock/h110m: enable ACPI LDN in SuperIO
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35370/1/src/mainboard/asrock/h110m/...
File src/mainboard/asrock/h110m/bootblock.c:
https://review.coreboot.org/c/coreboot/+/35370/1/src/mainboard/asrock/h110m/...
PS1, Line 35: pnp_write_config(acpi_dev, 0xe4, 0x70);
It seemed to me that this should be in bootblock, as it was done in other boards, before all LDNs ar […]
moved to the device tree
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35370
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbfec4dc82a1fbbfeb49c3dbd047509f5873d235
Gerrit-Change-Number: 35370
Gerrit-PatchSet: 2
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Thu, 12 Sep 2019 09:51:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-MessageType: comment