Attention is currently required from: Felix Singer, Nico Huber, Furquan Shaikh, Ravishankar Sarawadi, Srinidhi N Kaushik, Raj Astekar.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49055 )
Change subject: soc/intel/tigerlake: Add Kconfig options for each platform
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I too agree with Tim. Although, my interpretation may differ. :) […]
I think we should avoid SKU selection if possible, that seems like it could get really hairy... I would prefer to stick with features (use FSP A vs. FSP B), and I don't think it's too onerous to have to select one or the other for a TGL mainboard, as long as we have the right help text 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I575f28c7eaa82ed5d52ba7c9328a52e76d71dc5b
Gerrit-Change-Number: 49055
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Mon, 26 Apr 2021 22:12:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment