build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26942 )
Change subject: {arch,commonlib,cpu,device,drivers,lib,nb,sb}: Use "foo *bar" instead of "foo* bar" ......................................................................
Patch Set 3:
(38 comments)
https://review.coreboot.org/#/c/26942/3/src/device/oprom/include/x86emu/regs... File src/device/oprom/include/x86emu/regs.h:
https://review.coreboot.org/#/c/26942/3/src/device/oprom/include/x86emu/regs... PS3, Line 309: void * private; please, no space before tabs
https://review.coreboot.org/#/c/26942/3/src/device/oprom/include/x86emu/regs... PS3, Line 309: void * private; "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/device/oprom/yabel/compat/of.h File src/device/oprom/yabel/compat/of.h:
https://review.coreboot.org/#/c/26942/3/src/device/oprom/yabel/compat/of.h@3... PS3, Line 38: #define p32cast (int) (unsigned long) (void *) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/26942/3/src/device/oprom/yabel/compat/of.h@6... PS3, Line 62: int of_read (ihandle_t , void *, int); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/26942/3/src/device/oprom/yabel/compat/of.h@6... PS3, Line 62: int of_read (ihandle_t , void *, int); space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/#/c/26942/3/src/device/oprom/yabel/compat/of.h@6... PS3, Line 62: int of_read (ihandle_t , void *, int); function definition argument 'ihandle_t' should also have an identifier name
https://review.coreboot.org/#/c/26942/3/src/device/oprom/yabel/compat/of.h@6... PS3, Line 62: int of_read (ihandle_t , void *, int); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/26942/3/src/device/oprom/yabel/compat/of.h@6... PS3, Line 62: int of_read (ihandle_t , void *, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/#/c/26942/3/src/device/oprom/yabel/compat/of.h@6... PS3, Line 63: int of_write (ihandle_t, void *, int); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/26942/3/src/device/oprom/yabel/compat/of.h@6... PS3, Line 63: int of_write (ihandle_t, void *, int); function definition argument 'ihandle_t' should also have an identifier name
https://review.coreboot.org/#/c/26942/3/src/device/oprom/yabel/compat/of.h@6... PS3, Line 63: int of_write (ihandle_t, void *, int); function definition argument 'void *' should also have an identifier name
https://review.coreboot.org/#/c/26942/3/src/device/oprom/yabel/compat/of.h@6... PS3, Line 63: int of_write (ihandle_t, void *, int); function definition argument 'int' should also have an identifier name
https://review.coreboot.org/#/c/26942/3/src/drivers/aspeed/common/aspeed_cor... File src/drivers/aspeed/common/aspeed_coreboot.h:
https://review.coreboot.org/#/c/26942/3/src/drivers/aspeed/common/aspeed_cor... PS3, Line 76: void * ptr = malloc(size); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/drivers/intel/fsp1_0/fsp_util.c File src/drivers/intel/fsp1_0/fsp_util.c:
https://review.coreboot.org/#/c/26942/3/src/drivers/intel/fsp1_0/fsp_util.c@... PS3, Line 103: volatile u8 *find_fsp () space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/26942/3/src/drivers/intel/fsp1_0/fsp_util.c@... PS3, Line 224: FspHobListPtr = (void *)*((u32*) cbmem_find(CBMEM_ID_HOB_POINTER)); line over 80 characters
https://review.coreboot.org/#/c/26942/3/src/drivers/intel/fsp1_0/fsp_util.c@... PS3, Line 224: FspHobListPtr = (void *)*((u32*) cbmem_find(CBMEM_ID_HOB_POINTER)); "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/26942/3/src/drivers/intel/fsp1_0/fsp_util.c@... PS3, Line 297: FspHobListPtr = (void *)*((u32*) cbmem_find(CBMEM_ID_HOB_POINTER)); "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/26942/3/src/drivers/xgi/common/xgi_coreboot.... File src/drivers/xgi/common/xgi_coreboot.c:
https://review.coreboot.org/#/c/26942/3/src/drivers/xgi/common/xgi_coreboot.... PS3, Line 133: xgifb_info->video_vbase = hw_info->pjVideoMemoryAddress = (void *)(intptr_t)xgifb_info->video_base; line over 80 characters
https://review.coreboot.org/#/c/26942/3/src/northbridge/amd/amdht/ht_wrapper... File src/northbridge/amd/amdht/ht_wrapper.c:
https://review.coreboot.org/#/c/26942/3/src/northbridge/amd/amdht/ht_wrapper... PS3, Line 58: static const char *event_class_string_decodes[] = { static const char * array should probably be static const char * const
https://review.coreboot.org/#/c/26942/3/src/northbridge/amd/amdht/ht_wrapper... PS3, Line 93: static const char *event_string_decode(uint32_t event) { open brace '{' following function declarations go on the next line
https://review.coreboot.org/#/c/26942/3/src/northbridge/amd/pi/agesawrapper.... File src/northbridge/amd/pi/agesawrapper.c:
https://review.coreboot.org/#/c/26942/3/src/northbridge/amd/pi/agesawrapper.... PS3, Line 292: const void * agesa; "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/northbridge/intel/gm45/iommu.c File src/northbridge/intel/gm45/iommu.c:
https://review.coreboot.org/#/c/26942/3/src/northbridge/intel/gm45/iommu.c@5... PS3, Line 57: void * bar = (void *)pci_read_config32(igd, PCI_BASE_ADDRESS_0); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/northbridge/intel/nehalem/ramini... File src/northbridge/intel/nehalem/raminit.c:
https://review.coreboot.org/#/c/26942/3/src/northbridge/intel/nehalem/ramini... PS3, Line 2297: u8 *res_low, u8 *res_high, u8 val) please, no spaces at the start of a line
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb800/Amd.h File src/southbridge/amd/cimx/sb800/Amd.h:
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb800/Amd.h... PS3, Line 64: typedef AGESA_STATUS (*CALLOUT_ENTRY) (unsigned int Param1, unsigned int Param2, void * ConfigPtr); line over 80 characters
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb800/Amd.h... PS3, Line 64: typedef AGESA_STATUS (*CALLOUT_ENTRY) (unsigned int Param1, unsigned int Param2, void * ConfigPtr); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb800/Amd.h... PS3, Line 65: typedef AGESA_STATUS (*IMAGE_ENTRY) (IN OUT void * ConfigPtr); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb800/Amd.h... PS3, Line 66: typedef AGESA_STATUS (*MODULE_ENTRY) (IN OUT void * ConfigPtr); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb800/AmdSb... File src/southbridge/amd/cimx/sb800/AmdSbLib.h:
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb800/AmdSb... PS3, Line 31: typedef void (*CIM_IMAGE_ENTRY) (void * pConfig); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb800/late.... File src/southbridge/amd/cimx/sb800/late.c:
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb800/late.... PS3, Line 46: * prototype UINT32 (*SBCIM_HOOK_ENTRY)(UINT32 Param1, UINT32 Param2, void * pConfig) line over 80 characters
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb800/late.... PS3, Line 53: static u32 sb800_callout_entry(u32 func, u32 data, void * config) "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb900/Amd.h File src/southbridge/amd/cimx/sb900/Amd.h:
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb900/Amd.h... PS3, Line 64: typedef AGESA_STATUS (*CALLOUT_ENTRY) (unsigned int Param1, unsigned int Param2, void * ConfigPtr); line over 80 characters
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb900/Amd.h... PS3, Line 64: typedef AGESA_STATUS (*CALLOUT_ENTRY) (unsigned int Param1, unsigned int Param2, void * ConfigPtr); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb900/Amd.h... PS3, Line 65: typedef AGESA_STATUS (*IMAGE_ENTRY) (IN OUT void * ConfigPtr); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb900/Amd.h... PS3, Line 66: typedef AGESA_STATUS (*MODULE_ENTRY) (IN OUT void * ConfigPtr); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb900/AmdSb... File src/southbridge/amd/cimx/sb900/AmdSbLib.h:
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb900/AmdSb... PS3, Line 31: typedef void (*CIM_IMAGE_ENTRY) (void * pConfig); "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb900/late.... File src/southbridge/amd/cimx/sb900/late.c:
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb900/late.... PS3, Line 41: * prototype UINT32 (*SBCIM_HOOK_ENTRY)(UINT32 Param1, UINT32 Param2, void * pConfig) line over 80 characters
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/cimx/sb900/late.... PS3, Line 48: u32 sb900_callout_entry(u32 func, u32 data, void * config) "foo * bar" should be "foo *bar"
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/sr5650/sr5650.c File src/southbridge/amd/sr5650/sr5650.c:
https://review.coreboot.org/#/c/26942/3/src/southbridge/amd/sr5650/sr5650.c@... PS3, Line 339: mmio_base = (void *)(pci_read_config32(iommu_dev, 0x44) & 0xffffc000); line over 80 characters