Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44947 )
Change subject: util/mb/google: Update dalboz/trembyle template
......................................................................
Patch Set 1:
This looks okay to me, but one thing to consider here is that spd/ directory will not be present under the variant directory when a new variant is added using this script. Do we just want to leave this spd/ addition to Makefile here and in follow-up CLs, memory parts should get added? Would that be the workflow?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44947
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf
Gerrit-Change-Number: 44947
Gerrit-PatchSet: 1
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 31 Aug 2020 20:10:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment