Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48477 )
Change subject: Docs/cbfstool: Add details about memory mapped window handling
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48477/1/Documentation/cbfstool/mmap...
File Documentation/cbfstool/mmap_windows.svg:
PS1:
Looks fine, SVG files are basically XML, see CB:32334 for an example
Yeah, looking closely this seems fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48477
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf970f951e56d717e6a4f8845fc73f10d5a21dd0
Gerrit-Change-Number: 48477
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 08 Dec 2020 21:24:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment