Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42193 )
Change subject: soc/mediatek/mt8183: Fix some programming errors of DRAMC setting ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG@7 PS2, Line 7: soc/mediatek/mt8183: Fix some programming errors of DRAMC setting
this is found by code review.
Maybe something like
soc/mediatek/mt8183: Add missing register settings for channels
https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG@9 PS2, Line 9: Fix some programming errors.
this is found by code review.
Also mention the typo fix.
Also fix a typo (0x1 < 0) to (0x1 << 0).
https://review.coreboot.org/c/coreboot/+/42193/2//COMMIT_MSG@13 PS2, Line 13: TEST=Boots correctly on Kukui
no error before, […]
Yes, kukui should boot as before.
https://review.coreboot.org/c/coreboot/+/42193/4/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/42193/4/src/soc/mediatek/mt8183/dra... PS4, Line 894: Please remove this extra tab. Better to put format changes in a separate CL.