Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36824 )
Change subject: mb/amd/padmelon: Use Prairie Falcon configuration
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36824/2/src/mainboard/amd/padmelon/...
File src/mainboard/amd/padmelon/Kconfig:
https://review.coreboot.org/c/coreboot/+/36824/2/src/mainboard/amd/padmelon/...
PS2, Line 30: if PADMELON_MERLIN_FALCON
: config SOC_AMD_MERLINFALCON
: bool
: default y
: help
: AMD Merlin Falcon FP4 support
: endif
:
: if PADMELON_PRAIRIE_FALCON
: config SOC_AMD_PRAIRIEFALCON
: bool
: default y
: help
: AMD Prairie Falcon FP4 support
: endif
Need a name different from choice to work...
Yes, you're right. I was just typing something out and accidentally came up with the same name. I like what you chose.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36824
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1663e4403a32a7d626dd2fa06763f18f4230457e
Gerrit-Change-Number: 36824
Gerrit-PatchSet: 3
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 15 Nov 2019 16:07:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment