Attention is currently required from: Angel Pons, Patrick Rudolph.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60600 )
Change subject: nb/intel/{sandybridge,haswell}: Rename PCIe driver
......................................................................
Patch Set 1:
(1 comment)
File src/northbridge/intel/sandybridge/pcie.c:
https://review.coreboot.org/c/coreboot/+/60600/comment/777d080a_377e241a
PS1, Line 66: sa_pcie
Just an idea: How about naming it "nb_pcie"? So it reflects the file path (src/northbridge/intel/...) and we don't use too many names for the same thing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60600
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I019088fcaa7866d8002e6884c25e1acd1d149093
Gerrit-Change-Number: 60600
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 01 Jan 2022 15:10:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment