Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41832 )
Change subject: util/cbfstool: Add option --pow2page
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41832/2/util/cbfstool/cbfstool.c
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/41832/2/util/cbfstool/cbfstool.c@14...
PS2, Line 1422: " [-a alignment] [-y|--xip] [-P page-size] [-Q] [--ibb] "
There seems to be nothing in the help text that tells us what it is. Do […]
Done
https://review.coreboot.org/c/coreboot/+/41832/3/util/cbfstool/cbfstool.c
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/41832/3/util/cbfstool/cbfstool.c@12...
PS3, Line 1272: :
what's this colon doing?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41832
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4b5329c1df5afe49d27ab10220095d747024ad6
Gerrit-Change-Number: 41832
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 15 Jun 2020 17:41:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
