build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41057 )
Change subject: [WIP][DONOTMERGE]: Print GPIO DW's for every community ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41057/1/src/soc/intel/common/block/... File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/41057/1/src/soc/intel/common/block/... PS1, Line 317: for (k = 0; k < group_curr->size; k++) { suspect code indent for conditional statements (24, 8)
https://review.coreboot.org/c/coreboot/+/41057/1/src/soc/intel/common/block/... PS1, Line 320: group_curr->grp_name, k, comm->port, relative_pad_in_comm(comm, (comm_size+k))); line over 96 characters
https://review.coreboot.org/c/coreboot/+/41057/1/src/soc/intel/common/block/... PS1, Line 322: pad_conf = pcr_read32(comm->port, PAD_CFG_OFFSET(config_offset, l)); line over 96 characters