Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38855 )
Change subject: mb/google/dedede: Add USB configuration
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38855/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38855/1/src/mainboard/google/dedede...
PS1, Line 23: OC_SKIP
The concerned gpios are pulled up externally to 3.3V even though they are not used for OC events.
Right. My question was mostly that if there is any advantage of configuring the OC pins as NF since we know that they are not used anyways?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38855
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19f7563013c7d702d52b7f34a207a34abe308621
Gerrit-Change-Number: 38855
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 18 Feb 2020 23:19:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment