Swift Geek (Sebastian Grzywna) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36093 )
Change subject: mb/lenovo/x200: Add ThinkPad X301 as a variant
......................................................................
Patch Set 3:
For x301 gpio.c:
gpio19,22,60 should be GPI (general purpose input), it's pulled high on the board
gpio32 is set as GPI, should be native - CLKRUN# (if this one fails I blame EC FW, TPM chipie and intel strongly encourages its use)
Unused native functions (all pulled high, so GPI): gpio19,22,23
Unused USB OC# (all pulled high, so GPI): gpio29,31,41,43,44,45,46,47
Unused legacy PCI: gpio50,52,54 should be GPI, and gpio51,53,55 GPO High
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6a6059ccf15dd2e43ed4fc490c1d3c36aa1e817
Gerrit-Change-Number: 36093
Gerrit-PatchSet: 3
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Comment-Date: Fri, 18 Oct 2019 11:51:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment