Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45578 )
Change subject: mb/hp: Add HP EliteBook Folio 9480m ......................................................................
Patch Set 5:
(9 comments)
https://review.coreboot.org/c/coreboot/+/45578/5/Documentation/mainboard/hp/... File Documentation/mainboard/hp/9480m.md:
PS5: This file should at least be named `folio_9480m.md` for clarity
https://review.coreboot.org/c/coreboot/+/45578/5/Documentation/mainboard/hp/... PS5, Line 38: flash. We flash, we
https://review.coreboot.org/c/coreboot/+/45578/5/Documentation/mainboard/hp/... PS5, Line 42: chip. You chip, you
https://review.coreboot.org/c/coreboot/+/45578/5/Documentation/mainboard/hp/... PS5, Line 95: VGA It must be wired through a DP-to-VGA converter on board. HSW-LP does not have VGA
https://review.coreboot.org/c/coreboot/+/45578/5/Documentation/mainboard/hp/... PS5, Line 110: haed head
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... File src/mainboard/hp/folio_9480m/Kconfig:
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... PS5, Line 5: need needs
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... File src/mainboard/hp/folio_9480m/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... PS5, Line 11: FIXME Hm? I suspect DP1 is the DisplayPort connector, DP2 is the DP-to-VGA converter, and eDP goes to the LCD. Unless the DP connector is DP++, no HDMI ports should appear here.
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... File src/mainboard/hp/folio_9480m/gpio.c:
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... PS5, Line 6: = nit: add another space before the `=` for entries 0 to 9, for alignment purposes
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... File src/mainboard/hp/folio_9480m/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45578/5/src/mainboard/hp/folio_9480... PS5, Line 8: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_EDP, GMA_INT15_PANEL_FIT_DEFAULT, Has this been tested?