[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake|soc/intel/common: Add support for UARTs on PCH-H

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40405 )

Change subject: soc/intel/cannonlake|soc/intel/common: Add support for UARTs on PCH-H
......................................................................

Patch Set 16:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40405/15/src/soc/intel/common/block... 
File src/soc/intel/common/block/uart/uart.c:

https://review.coreboot.org/c/coreboot/+/40405/15/src/soc/intel/common/block... 
PS15, Line 273: fffff
> there's five `f`

Done

https://review.coreboot.org/c/coreboot/+/40405/15/src/soc/intel/common/block... 
PS15, Line 306: 	switch (dev->device) {
> Not all cases are handled here. […]

APL doesn't seem to support LPSS uart. The other IDs are secret and not part of the Linux kernel code.