Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33287 )
Change subject: payloads/libpayload: Update a Makefile and a wrapper of a compiler in libpayload in order to build sample payload for QEMU/ARM. ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/#/c/33287/6/payloads/libpayload/bin/lpgcc File payloads/libpayload/bin/lpgcc:
https://review.coreboot.org/#/c/33287/6/payloads/libpayload/bin/lpgcc@203 PS6, Line 203: $DEFAULT_CC $_LDFLAGS $HEAD_O $CMDLINE $_CFLAGS -lpayload $_LIBGCC -lc Why do you need -lc?
https://review.coreboot.org/#/c/33287/6/payloads/libpayload/drivers/Makefile... File payloads/libpayload/drivers/Makefile.inc:
https://review.coreboot.org/#/c/33287/6/payloads/libpayload/drivers/Makefile... PS6, Line 53: Why are you removing the ifneq?
https://review.coreboot.org/#/c/33287/6/payloads/libpayload/include/arm/arch... File payloads/libpayload/include/arm/arch/io.h:
https://review.coreboot.org/#/c/33287/6/payloads/libpayload/include/arm/arch... PS6, Line 37: a ARM doesn't support in/out. They are different address spaces, so it's not correct to assume it's a memory access.
https://review.coreboot.org/#/c/33287/6/payloads/libpayload/sample/Makefile File payloads/libpayload/sample/Makefile:
https://review.coreboot.org/#/c/33287/6/payloads/libpayload/sample/Makefile@... PS6, Line 35: Why are you removing the three archs?