View Change

4 comments:

• File payloads/libpayload/bin/lpgcc:

  • Patch Set #6, Line 203: $DEFAULT_CC $_LDFLAGS $HEAD_O $CMDLINE $_CFLAGS -lpayload $_LIBGCC -lc

    Why do you need -lc?

• File payloads/libpayload/drivers/Makefile.inc:

  • Patch Set #6, Line 53:

    Why are you removing the ifneq?

• File payloads/libpayload/include/arm/arch/io.h:

  • Patch Set #6, Line 37: a

    ARM doesn't support in/out. They are different address spaces, so it's not correct to assume it's a memory access.

• File payloads/libpayload/sample/Makefile:

  • Patch Set #6, Line 35:

    Why are you removing the three archs?

To view, visit change 33287. To unsubscribe, or for help writing mail filters, visit settings.