Attention is currently required from: Dinesh Gehlot, Eric Lai, Jamie Chen, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik, Sumeet R Pawnikar.
SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81614?usp=email )
Change subject: mb/google/brya/var/xol: Reduce power limits according to battery status
......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81614/comment/1134c008_0837ea79 :
PS2, Line 18: MSR PL2: 55W, MSR PL4: 114W
Sorry, I do not know what PTAT is.
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/81614/comment/2e8aa06d_19e605c2 :
PS4, Line 7: Configure power limits by battery status
Maybe: […]
Thanks for the suggestion. Modified from it due to the length.
https://review.coreboot.org/c/coreboot/+/81614/comment/c1b9e320_24a1e6cd :
PS4, Line 18: veified
verified
Done
https://review.coreboot.org/c/coreboot/+/81614/comment/52805753_f4dd5e9c :
PS4, Line 23: adaptor
adapt*e*r
Done
https://review.coreboot.org/c/coreboot/+/81614/comment/ee63ca65_0cb05c5b :
PS4, Line 29: adaptor
Ditto.
Done
File src/mainboard/google/brya/variants/xol/ramstage.c:
https://review.coreboot.org/c/coreboot/+/81614/comment/c509ffc5_e90c085e :
PS4, Line 27: printk(BIOS_INFO, "Cannot get PD power info\n");
Please also print the return value. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81614?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5d71e9edde0ecbd7aaf316cd754a6ebcff9da77d
Gerrit-Change-Number: 81614
Gerrit-PatchSet: 5
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 01 Apr 2024 23:32:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-MessageType: comment