Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34662 )
Change subject: Documentation/binaries: Add AMD FSP documentation ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... File Documentation/binaries/amd/AMD_FSP_family_17h.md:
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... PS6, Line 1: # FSP implementation differences between Intel and AMD
Maybe this document should just be about the AMD FSP, with the differences being a subsection?
This would be a change from the initial request on issue tracker. Can be done, would need to rewrite the whole document.
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... PS6, Line 17: available.
72 characters: […]
So I have to redo it cutting down to 72, not expand as Paul is asking? Also notice that I'm counting columns as it appears to the user, not including markdowns that don't show up to user (example, the link don't show, just the title of the link).
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/amd/... PS6, Line 25: > obtain the memory map from the PSP.
FSP-M is really being used as an initial call into the FSP and no longer really has anything to do w […]
As I mentioned above, this is a work in progress and as FSP evolves, correction will be needed. Corrections will be separate commits until it's no longer a work in progress, when that message will be removed.
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/cavi... File Documentation/binaries/cavium/index.md:
PS6:
You might want to give an explanation as to what the plan is with these placeholders. […]
Ok, as I'm not planning on filling them I shall remove them.
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/inde... File Documentation/binaries/index.md:
https://review.coreboot.org/c/coreboot/+/34662/6/Documentation/binaries/inde... PS6, Line 2:
Are you updating the main documentation page to point to this in a separate commit? Why not just ad […]
Because I want to leave the opportunity for Intel and Cavium also use the binaries documentation folder. Therefore I have to at least create an AMD folder inside the binaries folder.