Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47803 )
Change subject: vendorcode/intel/fsp: Add Elkhart Lake FSP headers for FSP v2341 ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FirmwareVersionInfoHob.h:
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... PS1, Line 39: ///< Offset 0 Index of Component Name There are some lines that are (unnecessary) too long. I guess since this is vendorcode and it is the same way done on other platforms (like tigerlake) and this is a file copied out of the FSP generation process it should be acceptable.
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... PS1, Line 3027: This is a looong list of parameters...just for Fspm.