[coreboot-gerrit] Change in coreboot[master]: libpayload/keyboard: Reset to scancode set #2 on exit

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47594 )

Change subject: libpayload/keyboard: Reset to scancode set #2 on exit
......................................................................

Patch Set 4:

(1 comment)

Patchset:

PS4:
> This change breaks all recent chromebooks that pass the keymap via ACPI from coreboot when they run  […]

I think we can safely switch to set2 with translation. IIRC, Linux (w/o the
ACPI properties) wouldn't switch the translation off but should still work.
The only problem I encountered with Linux was that it expected set2 after
a keyboard reset.

I don't know what the actual benefits of set2 w/o translation for an average
keyboard are. If somebody misses something with translation enabled, we can
still revisit this.

NB. The ACPI story seems odd. I guess one can't use a random payload and
still expect Linux to work. Unless we would teach all payloads to return
to the settings found initially.