Hello Patrick Rudolph, Balaji Manigandan, Lance Zhao, build bot (Jenkins), Furquan Shaikh, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32903
to look at the new patch set (#5).
Change subject: soc/intel/apollolake: Fix value stored to gnvs is never read
......................................................................
soc/intel/apollolake: Fix value stored to gnvs is never read
Clang Static Analyzer found gnvs is allocated, but it is never used.
Change sizeof(*gnvs) to sizeof(global_nvs_t) while adding ACPI GNVS
to CBMEM.
TEST=Built and boot up to kernel.
Signed-off-by: John Zhao john.zhao@intel.com
Change-Id: Ie9421af4a556d1d88183aa938ee2a124a10ab727
---
M src/soc/intel/apollolake/chip.c
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/32903/5
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32903
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9421af4a556d1d88183aa938ee2a124a10ab727
Gerrit-Change-Number: 32903
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: newpatchset