Attention is currently required from: Intel coreboot Reviewers, Jérémy Compostella, Krishna P Bhat D, Sowmya Aralguppe, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/86169?usp=email )
Change subject: soc/intel/common/block/cse: Add API to match current PM event ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86169/comment/ee029777_88981a38?usp... : PS1, Line 9: Introduce an API to read the CSME host firmware status register for
nit: Introduce an API to read the CSME (Converged Security and Management Engine) host firmware stat […]
Done
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/86169/comment/42fcdc8d_869accf1?usp... : PS1, Line 302: #define ME_HFSTS2_CUR_PM_EVENT_MASK (0xF << ME_HFSTS2_CUR_PM_EVENT_SHIFT)
Usually coreboot uses lower case for hexadecimal constant values.
Done
https://review.coreboot.org/c/coreboot/+/86169/comment/aee4970a_13cf68e8?usp... : PS1, Line 303: static uint8_t cse_get_hfs2_current_pm_event(void)
nit: An empty line would be nice.
Done
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/86169/comment/3a8e692c_4d16b496?usp... : PS1, Line 387: PWR_CYCLE_RESET_CMOFF = 0xB,
Usually coreboot uses lower case for hexadecimal constant values.
Done