Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40133 )
Change subject: soc/nvidia: Use SPDX for GPL-2.0-only files
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40133/2/src/soc/nvidia/tegra210/mip...
File src/soc/nvidia/tegra210/mipi_dsi.c:
https://review.coreboot.org/c/coreboot/+/40133/2/src/soc/nvidia/tegra210/mip...
PS2, Line 2: /* This file is part of the coreboot project. */
so should there be a newline added here? i don't have any strong opinion about this, so please eithe […]
I'll leave it as-is. In any case, the double license header is weird...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id987662ba96ad7e78e76aa5a66a59b313e82f724
Gerrit-Change-Number: 40133
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 05 Apr 2020 12:44:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment