Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29958 )
Change subject: qcs405: Combine BB with QC-Sec for ROM boot
......................................................................
Patch Set 29:
(1 comment)
https://review.coreboot.org/#/c/29958/29/src/soc/qualcomm/qcs405/Makefile.in...
File src/soc/qualcomm/qcs405/Makefile.inc:
https://review.coreboot.org/#/c/29958/29/src/soc/qualcomm/qcs405/Makefile.in...
PS29, Line 132: ifeq ($(CONFIG_QC_FLASH_SIMULATE_SDCARD),y)
: @printf "\nqgpt.py 512 sector size\n"
: python util/qualcomm/qgpt.py -s 512 $(objcbfs)/merged_bb_qcsec.mbn \
: $(objcbfs)/bootblock.bin
: else
the following commit removes this again. Maybe drop it here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29958
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2428fd067c0216d9cf6a63e218d1792788317db0
Gerrit-Change-Number: 29958
Gerrit-PatchSet: 29
Gerrit-Owner: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 17 Jun 2019 09:49:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment