Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32179
Change subject: sb/intel/{common,i82801dx}: Update debug code ......................................................................
sb/intel/{common,i82801dx}: Update debug code
This finishes the work done in 3e3b858 (sb/intel/ibexpeak: Update debug code to match other chips).
Found-by: Coverity Scan, CID 1229598 (DEADCODE) Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: I65df8f3363c62b364e096368a36ba5e9e8894c13 --- M src/southbridge/intel/common/smihandler.c M src/southbridge/intel/i82801dx/smihandler.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/32179/1
diff --git a/src/southbridge/intel/common/smihandler.c b/src/southbridge/intel/common/smihandler.c index b2cf49a..8a16aaa 100644 --- a/src/southbridge/intel/common/smihandler.c +++ b/src/southbridge/intel/common/smihandler.c @@ -418,7 +418,7 @@ } else if (tco_sts & (1 << 3)) { /* TIMEOUT */ /* Handle TCO timeout */ printk(BIOS_DEBUG, "TCO Timeout.\n"); - } else if (!tco_sts) { + } else { dump_tco_status(tco_sts); } } diff --git a/src/southbridge/intel/i82801dx/smihandler.c b/src/southbridge/intel/i82801dx/smihandler.c index 17bedab..18dc4d8 100644 --- a/src/southbridge/intel/i82801dx/smihandler.c +++ b/src/southbridge/intel/i82801dx/smihandler.c @@ -490,7 +490,7 @@ } else if (tco_sts & (1 << 3)) { /* TIMEOUT */ /* Handle TCO timeout */ printk(BIOS_DEBUG, "TCO Timeout.\n"); - } else if (!tco_sts) { + } else { dump_tco_status(tco_sts); } }