Attention is currently required from: Nicholas Sudsgaard.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80333?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins)
Change subject: device/azalia: Rework the verb table ......................................................................
device/azalia: Rework the verb table
This is a very experimental change and I would appreciate anyone's opinion on this. :)
My intentions are to make verb tables cleaner on the both the configuration and implementation side.
On the configuration side (i.e. hda_verbs.c) this method removes most superfluous comments (e.g. /* Subsystem ID */) and makes it more "structured".
On the implementation side I tried to make it easier to read (and hopefully maintain). For example, compare azalia_find_verb() and azalia_find_verb_table(). I also got rid of global variables (but introduced including c source files directly instead...).
Change-Id: If8b672e4fd800b34e5ba39fad174fcf1154b0a54 Signed-off-by: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com --- M src/device/azalia_device.c M src/include/device/azalia_device.h A src/include/device/azalia_table_exporter.c M src/mainboard/hp/snb_ivb_laptops/variants/2560p/hda_verb.c 4 files changed, 114 insertions(+), 103 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/80333/5