14 May
2019
14 May
'19
9:39 p.m.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29307 )
Change subject: src/drivers: Remove unneeded include <arch/io.h> ......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/#/c/29307/22/src/drivers/xgi/common/vb_init.c File src/drivers/xgi/common/vb_init.c:
https://review.coreboot.org/#/c/29307/22/src/drivers/xgi/common/vb_init.c@7 PS22, Line 7: * coreboot-specific includes added at top
It was intended that all coreboot related includes come indirectly from xgi_coreboot.h file. […]
so this "#include <delay.h>" should go to xgi_coreboot.h ...
--
To view, visit https://review.coreboot.org/c/coreboot/+/29307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia18c77876121594a272a07d56acfaa863d0ccb25
Gerrit-Change-Number: 29307
Gerrit-PatchSet: 22
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Tristan Corrick tristan@corrick.kiwi
Gerrit-Comment-Date: Tue, 14 May 2019 19:39:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-MessageType: comment