Nicolò has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37994 )
Change subject: mb/google/peppy: Add ALS as ACPI device ......................................................................
Patch Set 2:
(1 comment)
Was busy with university exams. I'll push a fix for the IRQ comment.
We mignt need a proper Mainboard level backend for probing HW and pass HW states to ACPI.
https://review.coreboot.org/c/coreboot/+/37994/2/src/mainboard/google/slippy... File src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/37994/2/src/mainboard/google/slippy... PS2, Line 179: Return (0xF)
how does the OS (linux, windows) handle this in the case where no ALS is present?
It's the same behavior for the touchscreen, not all models have it. (Only the P variant)