Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42460 )
Change subject: treewide: Configure PCI Bus Master based on Kconfig option
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42460/13/src/soc/intel/broadwell/hd...
File src/soc/intel/broadwell/hda.c:
https://review.coreboot.org/c/coreboot/+/42460/13/src/soc/intel/broadwell/hd...
PS13, Line 96: pci_dev_request_bus_master(dev);
AFAIUI, HDA init sequence sets bus master.
Why? we looked through many BSpecs/BWGs and didn't find much. I only recall
a single case where it was explicitly mentioned (GMA) but without any detail
why. For HDA, I could only find something in some sample assembler, likely
some copy-pasta that I wouldn't trust.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42460
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25565315a5ddf8d53097ac4cb4884ecebcc9c0a9
Gerrit-Change-Number: 42460
Gerrit-PatchSet: 13
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 05 Sep 2020 16:20:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment