Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41443 )
Change subject: device: Add support for resource allocator v4 ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/41443/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41443/3//COMMIT_MSG@10 PS3, Line 10: CB:39486
I’d prefer (at least addition) of commit hashes, so the git commands can easily be used.
Done
https://review.coreboot.org/c/coreboot/+/41443/3//COMMIT_MSG@12 PS3, Line 12: are some AMD : chipsets in the tree that do not really work well with the dynamic : resource allocation
Mention that other devices also had problems but were fixed in the mean-time?
Done
https://review.coreboot.org/c/coreboot/+/41443/3//COMMIT_MSG@14 PS3, Line 14: old(v3)
Please add a space.
Done
https://review.coreboot.org/c/coreboot/+/41443/3//COMMIT_MSG@15 PS3, Line 15: new(v4) of the resource allocator need to live side-by-side in the
Ditto.
Done
https://review.coreboot.org/c/coreboot/+/41443/3//COMMIT_MSG@22 PS3, Line 22: intializing
note: problem is a missing `i` between the 2nd and 3rd character
Done