Clay Daniels has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49112/4/util/superiotool/nuvoton.c File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/4/util/superiotool/nuvoton.c@... PS4, Line 571:
the indentations here should be tabs to be consistent with the existing code
You were right, I didn't see all the single spaces instead of tabs. Fixed.
https://review.coreboot.org/c/coreboot/+/49112/4/util/superiotool/nuvoton.c@... PS4, Line 597: {0x00,0xff,0x00,0x00,0x00,0x7f,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0xff,0x00,0x00,0x00,0x00,EOT}},
i'd expect some of the registers to be the gpio input registers. […]
I modeled NCT6797D on the NTC6791D directly above, and there are no NANA entries. I will leave it for now, pending any new information.