Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46687 )
Change subject: mb/google/asurada: Implement enable_requlator and regulator_is_enabled ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46687/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46687/2//COMMIT_MSG@13 PS2, Line 13: mainboard_enable_requlator - Configure the regulator as enabled / disabled. : mainboard_regulator_is_enabled - Query if the regulator is enabled. Consider using a list:
- mainboard_enable_requlator: Configure the regulator as enabled/disabled. - mainboard_regulator_is_enabled: Query if the regulator is enabled.
https://review.coreboot.org/c/coreboot/+/46687/2/src/mainboard/google/asurad... File src/mainboard/google/asurada/regulator.c:
https://review.coreboot.org/c/coreboot/+/46687/2/src/mainboard/google/asurad... PS2, Line 114: google_chromeec_regulator_enable This might return -1
https://review.coreboot.org/c/coreboot/+/46687/2/src/mainboard/google/asurad... PS2, Line 129: google_chromeec_regulator_is_enabled This might return -1. Should we check the return value?