Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation
......................................................................
Patch Set 6:
Patch Set 6:
Patch Set 4:
Previous parent is 69f6fd4 (69f6fd4589ee4d7cb0bfa12face26eba1fa0a973) - AGESA/binaryPI: Add NULL pointers check, Tue Jan 22 14:06:39 2019 +0000 . Rebasing on top of master...
Hi Mike!
Do you mind, could we ever merge this?
I just fixed some of the code style errors, which I felt problematic.
I still have the mobo and a CPU somewhere, I could test the build.
Regards
Balazs, I'm very sorry for delay, but I really hope to work on this patch in the near future (winter holidays). I also have this board, so we are in the same boat.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30987
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60fa0636ba41f5f1a6a3faa2764bf2f0a968cf90
Gerrit-Change-Number: 30987
Gerrit-PatchSet: 6
Gerrit-Owner: Balázs Vinarz
vinibali1@gmail.com
Gerrit-Reviewer: Balázs Vinarz
vinibali1@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Mike Banon
mikebdp2@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 23 Nov 2019 09:43:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment