Attention is currently required from: Felix Singer, Nico Huber. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47751 )
Change subject: nb/intel/sandybridge: Shorten `slotrank` to `rank` ......................................................................
Patch Set 3:
(3 comments)
File src/northbridge/intel/sandybridge/raminit_common.h:
https://review.coreboot.org/c/coreboot/+/47751/comment/bdb33319_1eb1e8b3 PS3, Line 427: #define FOR_ALL_POPULATED_RANKS for (rank = 0; rank < NUM_SLOTRANKS; rank++) if (ctrl->rankmap[channel] & (1 << rank)) line over 96 characters
https://review.coreboot.org/c/coreboot/+/47751/comment/78b0fb85_3e1b0b74 PS3, Line 427: #define FOR_ALL_POPULATED_RANKS for (rank = 0; rank < NUM_SLOTRANKS; rank++) if (ctrl->rankmap[channel] & (1 << rank)) Macros with complex values should be enclosed in parentheses
File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/47751/comment/f2961620_bd0c9950 PS3, Line 2638: if (ctrl->rankmap[channel] & (1 << rank)) { suspect code indent for conditional statements (24, 16)