Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33627 )
Change subject: arch/x86/acpi: use ALIGN_UP instead of ALIGN
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33627/1/src/arch/x86/acpi.c
File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/33627/1/src/arch/x86/acpi.c@816
PS1, Line 816: ALIGN_UP
Please, where this is defined ?
both ALIGN and ALIGN_UP are defined in src/commonlib/include/commonlib/helpers.h
https://review.coreboot.org/#/c/33627/1/src/arch/x86/acpi.c@1274
PS1, Line 1274: (
not needed
ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f1b9f9bbcafeb85a6ef5c10ce4b57edc0740e72
Gerrit-Change-Number: 33627
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 20 Jun 2019 16:29:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment