Patrick Georgi (patrick@georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5496
-gerrit
commit bf5c63b8a3abf2504845d177ce9274086f37f3ef Author: Patrick Georgi patrick@georgi-clan.de Date: Sun Apr 13 08:57:35 2014 +0200
it8728f: move prototypes to it8728f.h
early_serial.h includes it, so this still works. But long(er) term we want to de-emphasize early_serial.
Change-Id: I633f491bff5bc999e90dbd857bbade5cb35fde0c Signed-off-by: Patrick Georgi patrick@georgi-clan.de --- src/superio/ite/it8728f/early_serial.h | 15 --------------- src/superio/ite/it8728f/it8728f.h | 15 +++++++++++++++ 2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/src/superio/ite/it8728f/early_serial.h b/src/superio/ite/it8728f/early_serial.h index 3443e0d..1090545 100644 --- a/src/superio/ite/it8728f/early_serial.h +++ b/src/superio/ite/it8728f/early_serial.h @@ -25,19 +25,4 @@ #include <device/pnp_def.h> #include "it8728f.h"
-/* - * Superio low level commands - * Pass dev = PNP_DEV(superiobase, LDN) - */ -void it8728f_reg_write(device_t dev, u8 index, u8 value); - -/* Select 24MHz CLKIN (48MHz default). */ -void it8728f_24mhz_clkin(device_t dev); - -/* Enable the serial port(s). */ -void it8728f_enable_serial(device_t dev, u16 iobase); - -void it8728f_kill_watchdog(device_t dev); -void it8728f_enable_3vsbsw(device_t dev); - #endif diff --git a/src/superio/ite/it8728f/it8728f.h b/src/superio/ite/it8728f/it8728f.h index 9a92f5a..687fa13 100644 --- a/src/superio/ite/it8728f/it8728f.h +++ b/src/superio/ite/it8728f/it8728f.h @@ -41,4 +41,19 @@ #define IT8728F_CONFIG_REG_WATCHDOG 0x72 /* Watchdog control. */ #define IT8728F_CONFIG_REG_MFC 0x2a /* Multi-function control */
+/* + * Superio low level commands + * Pass dev = PNP_DEV(superiobase, LDN) + */ +void it8728f_reg_write(device_t dev, u8 index, u8 value); + +/* Select 24MHz CLKIN (48MHz default). */ +void it8728f_24mhz_clkin(device_t dev); + +/* Enable the serial port(s). */ +void it8728f_enable_serial(device_t dev, u16 iobase); + +void it8728f_kill_watchdog(device_t dev); +void it8728f_enable_3vsbsw(device_t dev); + #endif