Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79894?usp=email )
Change subject: mb/pcengines/apu2/Kconfig: select HUDSON_FADT_LEGACY_DEVICES ......................................................................
mb/pcengines/apu2/Kconfig: select HUDSON_FADT_LEGACY_DEVICES
The APU boards have an NCT5104D chip on the LPC bus that implements some serial ports that have the legacy IO port interface to the host and doesn't describe this in the ACPI tables, so select HUDSON_FADT_LEGACY_DEVICES to have the corresponding FADT bit set. Since this chip doesn't provide an 8042-compatible keyboard controller, don't select HUDSON_FADT_8042.
TEST=Surprisingly, this doesn't seem to make a difference to the Linux kernel; is creates all ttyS[0..3] devices with and without this patch.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I8872b8c3d6e0610630ba17a0fccdcf8cebb1d3c0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/79894 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/pcengines/apu2/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Arthur Heymans: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/pcengines/apu2/Kconfig b/src/mainboard/pcengines/apu2/Kconfig index 028d3b6..381bfcb 100644 --- a/src/mainboard/pcengines/apu2/Kconfig +++ b/src/mainboard/pcengines/apu2/Kconfig @@ -12,6 +12,7 @@ select SUPERIO_NUVOTON_NCT5104D select HAVE_PIRQ_TABLE select HAVE_ACPI_TABLES + select HUDSON_FADT_LEGACY_DEVICES select BOARD_ROMSIZE_KB_8192 select HAVE_SPD_IN_CBFS select MEMORY_MAPPED_TPM