Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44843 )
Change subject: cross-repo-cherrypick: Do not prepend "Original-" to "Cq-Depend:" ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44843/1/util/scripts/cross-repo-che... File util/scripts/cross-repo-cherrypick:
https://review.coreboot.org/c/coreboot/+/44843/1/util/scripts/cross-repo-che... PS1, Line 64: if (end==0) { Thanks for taking this on!
I'm not sure if this is correct, though: The way this works is that the commit message is replayed backwards (last line first) by the use of tax in line 51. When one of the BUG|BRANCH|TEST lines is identified, we assume that the last block (that came first) is over and add the Original-Commit-Id and Signed-off-by lines. Cq-Depend, however, can appear anywhere in the last block.
I'd simply make the /^Cq-Depend:/ condition print out the original line unchanged unconditionally.