Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62472 )
Change subject: soc/medaitek/mt8186: set pin drive strength to 8mA for NOR ......................................................................
Patch Set 4:
(3 comments)
File src/soc/mediatek/mt8186/spi.c:
https://review.coreboot.org/c/coreboot/+/62472/comment/9517faec_10d6d8e5 PS4, Line 154: /* Set pin drive to GPIO_DRV3 which is defined as 8mA in MT8186 */ The comment is not needed, as the warning log says the same.
https://review.coreboot.org/c/coreboot/+/62472/comment/3cc77118_f4b7c6ee PS4, Line 156: printk(BIOS_WARNING, "%s: failed to set pin drive for %d\n", 1. … set to 8 mA … 2. What won’t work, when it’s set incorrectly?
https://review.coreboot.org/c/coreboot/+/62472/comment/b2fdb1b7_2e2370e1 PS4, Line 160: gpio_get_driving(ptr[i].gpio)); Looks like a debug message?