Hello Seunghwan Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34080
to review the following change.
Change subject: mb/google/octopus: Add custom SAR values for Bluebird ......................................................................
mb/google/octopus: Add custom SAR values for Bluebird
Bluebird needs to use different SAR values than Casta. Bluebird sku id is 2.
BUG=none BRANCH=octopus TEST=build
Change-Id: I107a8519832fcf906b94f958a3dc508d19bb4727 Signed-off-by: Seunghwan Kim sh_.kim@samsung.com --- M src/mainboard/google/octopus/variants/casta/Makefile.inc A src/mainboard/google/octopus/variants/casta/mainboard.c 2 files changed, 34 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/34080/1
diff --git a/src/mainboard/google/octopus/variants/casta/Makefile.inc b/src/mainboard/google/octopus/variants/casta/Makefile.inc index 9fb63f5..152b46e 100644 --- a/src/mainboard/google/octopus/variants/casta/Makefile.inc +++ b/src/mainboard/google/octopus/variants/casta/Makefile.inc @@ -1,3 +1,4 @@ bootblock-y += gpio.c
ramstage-y += gpio.c +ramstage-y += mainboard.c diff --git a/src/mainboard/google/octopus/variants/casta/mainboard.c b/src/mainboard/google/octopus/variants/casta/mainboard.c new file mode 100644 index 0000000..217a994 --- /dev/null +++ b/src/mainboard/google/octopus/variants/casta/mainboard.c @@ -0,0 +1,33 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018 Google LLC + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <boardid.h> +#include <ec/google/chromeec/ec.h> +#include <sar.h> + +const char *get_wifi_sar_cbfs_filename(void) +{ + const char *filename = NULL; + uint32_t sku_id; + + if (google_chromeec_cbi_get_sku_id(&sku_id)) + return NULL; + + if (sku_id == 2) { + filename = "wifi_sar-bluebird.hex"; + } + + return filename; +}