Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40246 )
Change subject: soc/amd/picasso: add get_soc_config to chip.h
......................................................................
Patch Set 1:
Patch Set 1:
How does this differ from config_of_soc() (device.h)?
seems to be the same functionality, but with better error handling. i'll test if using config_of_soc works and then add an error message to config_of_soc in a separate patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40246
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I007c83cfe5063130c18819925844b6c643cf0232
Gerrit-Change-Number: 40246
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 Apr 2020 11:50:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment