Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32022 )
Change subject: nb/amd/pi, mb/amd/bettong: Fix null pointer checks
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32022/4/src/mainboard/amd/bettong/BiosCallOu...
File src/mainboard/amd/bettong/BiosCallOuts.c:
https://review.coreboot.org/#/c/32022/4/src/mainboard/amd/bettong/BiosCallOu...
PS4, Line 125: if (dev == 0)
Please test pointers for NULL instead of 0. Or just (!dev).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32022
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie578787c3c26a1f3acb4567c135486667e88a888
Gerrit-Change-Number: 32022
Gerrit-PatchSet: 4
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 07 Apr 2019 03:30:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment