Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )
Change subject: util/inteltool: add many missing registers for skl/kbl ......................................................................
Patch Set 6: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/35189/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35189/6//COMMIT_MSG@9 PS6, Line 9: Kabylake Kaby Lake
https://review.coreboot.org/c/coreboot/+/35189/6//COMMIT_MSG@23 PS6, Line 23: please add the Intel document number that you used
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/usb.c File util/inteltool/usb.c:
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/usb.c@35 PS6, Line 35: 4 8?
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/usb.c@36 PS6, Line 36: 4 2
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/usb.c@120 PS6, Line 120: 0x80EF 0x80EC