Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47335 )
Change subject: mb/intel/adlrvp: Adopt overridetree.cb for ADL RVP mainboards
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47335/4/src/mainboard/intel/adlrvp/...
File src/mainboard/intel/adlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/47335/4/src/mainboard/intel/adlrvp/...
PS4, Line 53: default "variants/baseboard/devicetree.cb"
I would prefer to avoid having the "variants/baseboard/" subdirectory, and simply place the baseboard files in "src/mb/intel/adlrvp/"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47335
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3591e214ed32dc9baaa49b92dff59579f29c7bd6
Gerrit-Change-Number: 47335
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subi.banik@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 07 Nov 2020 13:44:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment