build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38504 )
Change subject: soc/intel/tigerlake: Enable SATA ......................................................................
Patch Set 1:
(25 comments)
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 124: /* SATA */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 125: dev = pcidev_on_root(PCH_DEV_SLOT_SATA, 0); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 125: dev = pcidev_on_root(PCH_DEV_SLOT_SATA, 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 126: if (!dev) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 126: if (!dev) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 127: params->SataEnable = 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 127: params->SataEnable = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 128: else { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 128: else { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 129: params->SataEnable = dev->enabled; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 129: params->SataEnable = dev->enabled; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 130: params->SataMode = config->SataMode; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 130: params->SataMode = config->SataMode; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 131: params->SataSalpSupport = config->SataSalpSupport; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 131: params->SataSalpSupport = config->SataSalpSupport; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 132: memcpy(params->SataPortsEnable, config->SataPortsEnable, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 132: memcpy(params->SataPortsEnable, config->SataPortsEnable, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 133: sizeof(params->SataPortsEnable)); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 133: sizeof(params->SataPortsEnable)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 134: memcpy(params->SataPortsDevSlp, config->SataPortsDevSlp, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 134: memcpy(params->SataPortsDevSlp, config->SataPortsDevSlp, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 135: sizeof(params->SataPortsDevSlp)); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 135: sizeof(params->SataPortsDevSlp)); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 136: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38504/1/src/soc/intel/tigerlake/fsp... PS1, Line 136: } please, no spaces at the start of a line