[coreboot-gerrit] Change in coreboot[master]: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build ...

[Angel Pons (Code Review)]

Attention is currently required from: Bill XIE, Nico Huber, Patrick Rudolph, Julius Werner, Arthur Heymans, Michael Niewöhner, Kyösti Mälkki, Aaron Durbin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51671 )

Change subject: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build time
......................................................................

Patch Set 27:

(3 comments)

File src/arch/x86/Kconfig:

https://review.coreboot.org/c/coreboot/+/51671/comment/472b3dee_1e1c5f30 
PS27, Line 355: present
nit: Missing a period

File src/arch/x86/bootblock.ld:

https://review.coreboot.org/c/coreboot/+/51671/comment/1618e69c_ff9a84cd 
PS27, Line 57: 	_ID_SECTION_END = SIZEOF(.ecfw_ptr) && SIZEOF(.id) > _ID_SECTION_END - _ECFW_PTR ? _ECFW_PTR : _ID_SECTION_END;
Reposting my CB:51059 comment about this:
> .id exists for compatibility with legacy software. If it gets placed elsewhere, then it's like it wasn't anywhere to begin with.

File src/ec/hp/kbc1126/Kconfig:

https://review.coreboot.org/c/coreboot/+/51671/comment/b4971514_e13919c1 
PS27, Line 30: if KBC1126_FIRMWARE
I'd much prefer to always add the `.ecfw_ptr` section, even when not adding the actual EC firmware (pointers would simply be invalid). This way, Jenkins will build-test it, and will catch build errors related to `.ecfw_ptr`.