Attention is currently required from: Bill XIE, Nico Huber, Patrick Rudolph, Julius Werner, Arthur Heymans, Michael Niewöhner, Kyösti Mälkki, Aaron Durbin.
View Change
3 comments:
File src/arch/x86/Kconfig:
File src/arch/x86/bootblock.ld:
Patch Set #27, Line 57: _ID_SECTION_END = SIZEOF(.ecfw_ptr) && SIZEOF(.id) > _ID_SECTION_END - _ECFW_PTR ? _ECFW_PTR : _ID_SECTION_END;
Reposting my CB:51059 comment about this:
.id exists for compatibility with legacy software. If it gets placed elsewhere, then it's like it wasn't anywhere to begin with.
File src/ec/hp/kbc1126/Kconfig:
Patch Set #27, Line 30: if KBC1126_FIRMWARE
I'd much prefer to always add the `.ecfw_ptr` section, even when not adding the actual EC firmware (pointers would simply be invalid). This way, Jenkins will build-test it, and will catch build errors related to `.ecfw_ptr`.
To view, visit change 51671. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f0de0c4d7283e630242fbe84a46e0547783c49e
Gerrit-Change-Number: 51671
Gerrit-PatchSet: 27
Gerrit-Owner: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Iru Cai <mytbk920423@gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Attention: Aaron Durbin <adurbin@chromium.org>
Gerrit-Comment-Date: Fri, 26 Nov 2021 10:05:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment