Attention is currently required from: Rex-BC Chen, Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61133 )
Change subject: soc/mediatek/mt8186: Support DRAM fast calibration using blob ......................................................................
Patch Set 2:
(4 comments)
File src/soc/mediatek/common/memory.c:
https://review.coreboot.org/c/coreboot/+/61133/comment/c5629fb9_af0d5236 PS2, Line 145: init_dram_by_params it seems a little weird if we always do this (init_dram_by_params) then another re-calibrate for blobs. I'd rather prefer
if (CONFIG(MEDIATEK_DRAM_INIT_ALWAYS_BLOB)) { if (run_dram_blob(dparam) < 0) return -2; } else { init_dram_by_params(dparam); }
To make it clear.
https://review.coreboot.org/c/coreboot/+/61133/comment/48c89f3a_2d222bcb PS2, Line 150: /* Initialize header version & size */ : initialize_dramc_param(dparam); I think we should not re-initialize header version & size again, given the header should be the same as last time.
https://review.coreboot.org/c/coreboot/+/61133/comment/bc60775d_52dd4014 PS2, Line 153: dparam->header.config |= DRAMC_CONFIG_FAST_K; will this break checksum?
https://review.coreboot.org/c/coreboot/+/61133/comment/be99a62f_8681b348 PS2, Line 158: < previously we are only checking '!= 0'. Do you expect mt_mem_test to return any >0 and still success?