Attention is currently required from: Raul Rangel, Nikolai Vyssotski, Rob Barnes, Julian Schroeder.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57294 )
Change subject: device/dram: Add addtional LPDDR4 speed grades
......................................................................
Patch Set 2:
(2 comments)
File src/device/dram/lpddr4.c:
https://review.coreboot.org/c/coreboot/+/57294/comment/f4a969cc_f562ca11
PS1, Line 51: 934
Could go either way. JEDEC Standard No. 79-4C / Table 169 says DDR4-1866 tck(avg) min = 1.071ns. […]
ok, since the nominal value should be within the range specified by min_clock_mhz and max_clock_mhz, we should probably go with 934 here to be on the safe side
https://review.coreboot.org/c/coreboot/+/57294/comment/6bc304f1_81164e07
PS1, Line 81: 2137
JEDEC Standard No. 209-4 Table 88 says LPDDR4-4266 tck(avg) min = 0.467ns. 1/0. […]
2134 sounds correct to me
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie7706fd4ad5a7df68c07b8ca43261429ba140c61
Gerrit-Change-Number: 57294
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Comment-Date: Sat, 04 Sep 2021 02:33:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment